-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/gorm.io/gorm.v1: Add err check #940
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c808b17
gorm.io/gorm.v1: add err check
vmlellis f6b5a3d
Merge branch 'v1' into v1
vmlellis 1c7b9f3
Merge branch 'v1' into v1
knusbaum 6b8910f
gorm.io/gorm.v1: fix test case
vmlellis d8ea4f2
gorm.io/gorm.v1: delete blank lines
vmlellis 02d669e
Merge branch 'v1' into v1
vmlellis 0bcd078
Merge branch 'v1' into v1
knusbaum 1505f4b
gorm.io/gorm.v1: Update comment
vmlellis 8c976ac
Merge branch 'v1' into v1
vmlellis 3939337
Merge branch 'v1' into v1
gbbr 6ea3a27
Merge branch 'v1' into v1
gbbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for using
SetTag()
instead oftracer.WithError()
here? If not, the latter would probably be preferable as it reduces the burden on the reviewer to verify that the two are interchangable.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@felixge Maybe there ref
dd-trace-go/contrib/jinzhu/gorm/gorm.go
Line 141 in 63dea35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to this: