contrib/go-chi/chi.v5: support for chi v5 package #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
suggested changes
Mar 22, 2021
| // Copyright 2016 Datadog, Inc. | ||
|
|
||
| // Package chi provides tracing functions for tracing the go-chi/chi package (https://github.com/go-chi/chi). | ||
| package chi // import "gopkg.in/DataDog/dd-trace-go.v1/contrib/go-chi/chi" |
There was a problem hiding this comment.
You should fix the canonical import paths throughout too. Just grep the entire repo for go-chi to make sure all paths are updates correctly. Same for the line just above this one, the documentation.
|
Duplicate of #858. Sorry for not noticing earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #877