Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: add support for Fargate 1.4 #863

Merged
merged 2 commits into from
Mar 10, 2021
Merged

internal: add support for Fargate 1.4 #863

merged 2 commits into from
Mar 10, 2021

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Mar 8, 2021

/proc/self/cgroup structure has changed with Fargate 1.4, which broke
our container ID detection algorithm. This change fixes it.

References:

@gbbr gbbr added this to the 1.30.0 milestone Mar 8, 2021
brettlangdon
brettlangdon previously approved these changes Mar 9, 2021
rochdev
rochdev previously approved these changes Mar 9, 2021
felixge
felixge previously approved these changes Mar 9, 2021
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

internal/container.go Show resolved Hide resolved
/proc/self/cgroup structure has changed with Fargate 1.4, which broke
our container ID detection algorithm. This change fixes it.
@gbbr gbbr requested a review from felixge March 10, 2021 13:54
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants