ddtrace/tracer: Add WithLogStartup startup option #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriklarko
force-pushed
the
withlogstartup
branch
from
57e1269
to
8427f4e
Compare
eriklarko
changed the title
eriklarko
force-pushed
the
withlogstartup
branch
from
8427f4e
to
377406a
Compare
eriklarko
force-pushed
the
withlogstartup
branch
from
377406a
to
2ddfdf8
Compare
gbbr
reviewed
Mar 5, 2021
ddtrace/tracer/option_test.go
Outdated
|
|
||
| func TestWithLogStartup(t *testing.T) { | ||
| var c config | ||
| defaultValue := c.logStartup |
There was a problem hiding this comment.
We already know that the zero-value of a boolean is false, so we can simplify this and just do:
c := newConfig()
assert.False(t, c.logStartup)
WithLogStartup()(&c)
assert.True(t, c.logStartup)That should do for the whole test. I don't think there's a need for documentation either. It's pretty self-explanatory.
There was a problem hiding this comment.
I agree. Inverting a value like that is a bit opaque, it's much easier to grasp the code if the values are more explicit.
gbbr
reviewed
Mar 8, 2021
ddtrace/tracer/option.go
Outdated
| @@ -443,6 +443,13 @@ func WithHostname(name string) StartOption { | |||
| } | |||
| } | |||
|
|
|||
| // WithLogStartup allows control over whether to print the startup log or not | |||
| func WithLogStartup(logStartup bool) StartOption { | |||
There was a problem hiding this comment.
Except maybe let's rename the argument to something else.
Suggested change
| func WithLogStartup(logStartup bool) StartOption { | |
| func WithLogStartup(yes bool) StartOption { |
There was a problem hiding this comment.
I'm going with enabled to be consistent with our other boolean StartOptions.
gbbr
reviewed
Aug 31, 2021
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
gbbr
approved these changes
Sep 1, 2021
gbbr
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the proposal described in #861