contrib/gorilla/mux: added optional middlewares on mux tracer router #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
suggested changes
Feb 22, 2021
gbbr
reviewed
Feb 24, 2021
dianashevchenko
force-pushed
the
shevchenko/add-mux-middleware
branch
from
6ac5e3d
to
90e1635
Compare
gbbr
reviewed
Mar 3, 2021
gbbr
previously approved these changes
Mar 5, 2021
|
@dianashevchenko can you please rebase this on |
Added middlewares which can be applied to recorder request information as span tags. WithHeaderTags will add request headers(except x-datadog-* prefixed) as span tags and WithQueryParameters will add request query parameters as a single span tag. Fixes #480
Updated docs for the implementation. Renamed struct fields and methods to reflect the functionality better
Refactored code of the TraceAndServe function to use one config parameter, and changed its usage. Added QueryParamTags field that would enable appending query params to the http.url tag. It is currently available only for the gorilla/mux package
Removed sprintf and added doc comment to TraceConfig
dianashevchenko
force-pushed
the
shevchenko/add-mux-middleware
branch
from
5f2e445
to
feebab2
Compare
gbbr
reviewed
Mar 12, 2021
contrib/gorilla/mux/option.go
Outdated
| } | ||
| } | ||
|
|
||
| func headerTagsFromRequest(req *http.Request) ddtrace.StartSpanOption { |
There was a problem hiding this comment.
Please move this into gorilla/mux/mux.go where it is used. It's out of place here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added middlewares which can be applied to recorder request information as span tags. WithHeaderTags will add request headers(except x-datadog-* prefixed) as span tags and WithQueryParameters will add request query parameters as a single span tag.
Fixes #480