Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: Start() doesn't unlock mutex on error #819

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

felixge
Copy link
Member

@felixge felixge commented Jan 18, 2021

Hopefully this PR fixes a non-imaginary bug : ). PTAL

@felixge felixge force-pushed the felix.geisendoerfer/fix-start-mutex-unlock-bug branch from 4c8c2c8 to 6268067 Compare January 18, 2021 09:16
@felixge felixge changed the title Fix: mu remains locked if Start() returns an error profiler: Start() doesn't unlock mutex on error Jan 18, 2021
@pmbauer pmbauer added this to the Triage milestone Jan 18, 2021
Copy link
Member

@pmbauer pmbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@felixge felixge merged commit d7e00ea into v1 Jan 26, 2021
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
@knusbaum knusbaum modified the milestones: Triage, 1.29.0 May 26, 2021
@Julio-Guerra Julio-Guerra deleted the felix.geisendoerfer/fix-start-mutex-unlock-bug branch December 13, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants