-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/gorilla/mux: option for skipping tracing #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for contributing to dd-trace-go! Please take a moment to read our short contribution guidelines: https://github.com/DataDog/dd-trace-go/blob/v1/CONTRIBUTING.md
Wow, you were fast. I was about too 👍 |
@gbbr what about now? :) |
Better! Thanks a lot! Usually it's done the other way around and the PR would come last, so I jumped in to look :) Will review soon... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One last small thing :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I want to run unit tests on this before merging. |
This update adds an option called WithSkippingFunc, which can be used for skipping tracing based on request path.
Issue #790