{profiler,ddtrace/tracer}: add UDS client options #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the overriding the HTTP client and transport. As a convenience, provide an option to create a custom client and transport that accesses a Unix Domain Socket. Modified upload tests to exercise both default and custom HTTP clients.
pmbauer
commented
Dec 14, 2020
gbbr
changed the title
pmbauer
changed the title
gbbr
reviewed
Dec 15, 2020
gbbr
changed the title
gbbr
reviewed
Dec 15, 2020
There was a problem hiding this comment.
This LGTM, but I'd love it if we could clean up / sort out the tests a bit to make them easier to figure out.
None of the functions are clear on what they do and the multiple return values (e.g. io.Closer, string, testServerWaiter) are not clarified. Perhaps named return variables will help here.
gbbr
reviewed
Dec 16, 2020
gbbr
previously approved these changes
Dec 16, 2020
pmbauer
force-pushed
the
pmbauer/profiler-uds
branch
from
29a3885
to
dd3b1ac
Compare
gbbr
approved these changes
Dec 16, 2020
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some customers need to override networking over which the profiler sends data.
Description