-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: v3 upload and metrics #781
Conversation
NB: this pull is not ready until intake backend code to support the change is deployed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This seems like an improvement :)
7cc659f
to
d63451b
Compare
The new format replaces ordinal parallel arrays for the attachments, substituting canonical names for the attachment types. - heap - cpu - block - mutex - goroutines Example upload ```bash curl -i \ -H "DD-API-KEY:redacted" \ -F recording-start=$(date -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F recording-end=$(date -d '+1 min' -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F tags\[\]=host:test-host \ -F tags\[\]=service:test-service \ -F tags\[\]=language:go \ -F data\[heap.pprof\]=@heap.pprof \ -F data\[cpu.pprof\]=@cpu.pprof \ -F data\[goroutines.pprof\]=@goroutines.pprof \ -F data\[block.pprof\]=@block.pprof \ -F data\[mutex.pprof\]=@mutex.pprof \ -F version=3 \ -F family=go \ https://intake.profile.datadoghq.com/v1/input ```
d63451b
to
3cfdb82
Compare
* normalize upload filenames and string ids * add metric profile and heap metrics * add gc metrics
Gabriel initially screened this pull (profile v3 uploads) pending the server side changes being deployed to support the new uploads Since then, #801 was approved and merged into the profiling-v3-branch since it depends on 781. The requisite server-side changes to support this client change are in production and we’ve also tested the changes with one of our own production services in prod |
9c03aa3
to
35f3b68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine to me.
* profile V3 upload format The new format replaces ordinal parallel arrays for the attachments, substituting canonical names for the attachment types. - heap - cpu - block - mutex - goroutines Example upload ```bash curl -i \ -H "DD-API-KEY:redacted" \ -F recording-start=$(date -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F recording-end=$(date -d '+1 min' -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F tags\[\]=host:test-host \ -F tags\[\]=service:test-service \ -F tags\[\]=language:go \ -F data\[heap.pprof\]=@heap.pprof \ -F data\[cpu.pprof\]=@cpu.pprof \ -F data\[goroutines.pprof\]=@goroutines.pprof \ -F data\[block.pprof\]=@block.pprof \ -F data\[mutex.pprof\]=@mutex.pprof \ -F version=3 \ -F family=go \ https://intake.profile.datadoghq.com/v1/input ``` * drive-by clarifying comment on batch end field * gofmt fixes * profiles: add custom metrics payload (#801) * normalize upload filenames and string ids * add metric profile and heap metrics * add gc metrics * fixup copyright date
The new format replaces ordinal parallel arrays for the attachments,
substituting canonical names for the attachment types.
Example upload