profiler: v3 upload and metrics #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: this pull is not ready until intake backend code to support the change is deployed. |
gbbr
reviewed
Nov 26, 2020
pmbauer
force-pushed
the
pmbauer/profiling-v3-input
branch
from
7cc659f
to
d63451b
Compare
The new format replaces ordinal parallel arrays for the attachments, substituting canonical names for the attachment types. - heap - cpu - block - mutex - goroutines Example upload ```bash curl -i \ -H "DD-API-KEY:redacted" \ -F recording-start=$(date -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F recording-end=$(date -d '+1 min' -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F tags\[\]=host:test-host \ -F tags\[\]=service:test-service \ -F tags\[\]=language:go \ -F data\[heap.pprof\]=@heap.pprof \ -F data\[cpu.pprof\]=@cpu.pprof \ -F data\[goroutines.pprof\]=@goroutines.pprof \ -F data\[block.pprof\]=@block.pprof \ -F data\[mutex.pprof\]=@mutex.pprof \ -F version=3 \ -F family=go \ https://intake.profile.datadoghq.com/v1/input ```
pmbauer
force-pushed
the
pmbauer/profiling-v3-input
branch
from
d63451b
to
3cfdb82
Compare
* normalize upload filenames and string ids * add metric profile and heap metrics * add gc metrics
|
Gabriel initially screened this pull (profile v3 uploads) pending the server side changes being deployed to support the new uploads Since then, #801 was approved and merged into the profiling-v3-branch since it depends on 781. The requisite server-side changes to support this client change are in production and we’ve also tested the changes with one of our own production services in prod |
pmbauer
force-pushed
the
pmbauer/profiling-v3-input
branch
from
9c03aa3
to
35f3b68
Compare
knusbaum
approved these changes
Jan 7, 2021
dianashevchenko
pushed a commit
that referenced
this pull request
Feb 8, 2021
* profile V3 upload format The new format replaces ordinal parallel arrays for the attachments, substituting canonical names for the attachment types. - heap - cpu - block - mutex - goroutines Example upload ```bash curl -i \ -H "DD-API-KEY:redacted" \ -F recording-start=$(date -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F recording-end=$(date -d '+1 min' -u --iso-8601=seconds | sed 's/\+.*/Z/') \ -F tags\[\]=host:test-host \ -F tags\[\]=service:test-service \ -F tags\[\]=language:go \ -F data\[heap.pprof\]=@heap.pprof \ -F data\[cpu.pprof\]=@cpu.pprof \ -F data\[goroutines.pprof\]=@goroutines.pprof \ -F data\[block.pprof\]=@block.pprof \ -F data\[mutex.pprof\]=@mutex.pprof \ -F version=3 \ -F family=go \ https://intake.profile.datadoghq.com/v1/input ``` * drive-by clarifying comment on batch end field * gofmt fixes * profiles: add custom metrics payload (#801) * normalize upload filenames and string ids * add metric profile and heap metrics * add gc metrics * fixup copyright date
This was referenced Mar 11, 2021
This was referenced Mar 13, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format replaces ordinal parallel arrays for the attachments,
substituting canonical names for the attachment types.
Example upload