Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

profiler: set profiler upload timeout to 10s #768

Merged
merged 1 commit into from
Oct 27, 2020
Merged

profiler: set profiler upload timeout to 10s #768

merged 1 commit into from
Oct 27, 2020

Conversation

dbenamydd
Copy link
Collaborator

This brings it in line with the other pprof-based profilers

@dbenamydd
Set profiler upload timeout to 10s
724e4f6 
This brings it in line with the other pprof-based profilers
@gbbr gbbr changed the title Set profiler upload timeout to 10s profiler: set profiler upload timeout to 10s Oct 27, 2020
@gbbr gbbr added this to the 1.28.0 milestone Oct 27, 2020
@gbbr
Copy link
Contributor

gbbr commented Oct 27, 2020

Looks like our milsetone check is broken 😞

@gbbr gbbr merged commit 008fc81 into v1 Oct 27, 2020
@gbbr gbbr deleted the dbenamydd-patch-1 branch October 27, 2020 12:07
@dbenamydd
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbr gbbr gbbr approved these changes

@knusbaum knusbaum Awaiting requested review from knusbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dbenamydd @gbbr