-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/jmoiron/sqlx: allow options to sqlx.Open #762
contrib/jmoiron/sqlx: allow options to sqlx.Open #762
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Please consider opening an issue in the future first, before contributing features (guidelines here).
Please rebase on |
79214cc
to
f15487c
Compare
Thank you for review!! I've rebased and got CI to pass. I'm sorry that I missed guidelines. I'll be more careful in future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
This PR provides additional options to open database connection with sqlx.Open, same as following PullRequest.
#466
It allow us to override some parameters, such as service name, for multiple database connection.