contrib/jmoiron/sqlx: allow options to sqlx.Open #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
previously approved these changes
Oct 15, 2020
There was a problem hiding this comment.
LGTM. Thanks! Please consider opening an issue in the future first, before contributing features (guidelines here).
|
Please rebase on |
tzmfreedom
force-pushed
the
feature/add_option_parameter_to_sqlx
branch
from
79214cc
to
f15487c
Compare
|
Thank you for review!! I've rebased and got CI to pass. I'm sorry that I missed guidelines. I'll be more careful in future. |
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides additional options to open database connection with sqlx.Open, same as following PullRequest.
#466
It allow us to override some parameters, such as service name, for multiple database connection.