ddtrace/tracer: add WithDebugStack StartOption to configure stack traces. #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ces. By default a stack trace is collected when a span is finished with an error. This can be disabled by passing tracer.NoDebugStack to span.Finish(). Sometimes it is desirable to disable this option globally, which is now possible with the WithDebugStack StartOption that this commit introduces.
knusbaum
commented
Sep 21, 2020
| @@ -59,7 +60,7 @@ loop: | |||
| } | |||
| } | |||
|
|
|||
| // TestTracerFrenetic does frenetic testing in a scenario where the tracer is started | |||
| // TestTracerCleanStop does frenetic testing in a scenario where the tracer is started | |||
There was a problem hiding this comment.
Unrelated doc change
gbbr
reviewed
Sep 21, 2020
gbbr
previously approved these changes
Sep 21, 2020
gbbr
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default a stack trace is collected when a span is finished with an
error. This can be disabled by passing tracer.NoDebugStack to
span.Finish(). Sometimes it is desirable to disable this option globally,
which is now possible with the WithDebugStack StartOption that this commit
introduces.