Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/garyburd/redigo: support go 1.15 #731

Merged
merged 1 commit into from
Sep 16, 2020
Merged

contrib/garyburd/redigo: support go 1.15 #731

merged 1 commit into from
Sep 16, 2020

Conversation

lbcjbb
Copy link
Contributor

@lbcjbb lbcjbb commented Sep 12, 2020

go 1.15 doesn't support to create context from nil parent.

@lbcjbb lbcjbb changed the title [contrib/garyburd/redigo] Support go 1.15 contrib/garyburd/redigo: support go 1.15 Sep 12, 2020
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch.

contrib/garyburd/redigo/redigo.go Outdated Show resolved Hide resolved
go 1.15 doesn't support to create context from nil parent.

Fixes #732
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@knusbaum knusbaum added this to the 1.27.0 milestone Sep 16, 2020
@knusbaum knusbaum merged commit e7d03f2 into DataDog:v1 Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants