contrib/twitchtv/twirp: Add explicit reference to the request span #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready. I've marked it as a draft for now, until the problem and solution in #725 are confirmed. |
knusbaum
requested changes
Sep 16, 2020
knusbaum
requested changes
Sep 18, 2020
mickeyreiss
force-pushed
the
fix-twirp-serverhooks
branch
from
949c53a
to
9cea5e3
Compare
mickeyreiss
force-pushed
the
fix-twirp-serverhooks
branch
from
9cea5e3
to
6f22ca9
Compare
knusbaum
reviewed
Sep 21, 2020
There was a problem hiding this comment.
@mickeyreiss The changes look great.
Would you mind adding a test for this?
knusbaum
approved these changes
Sep 22, 2020
|
Perfect. Thanks for the help, @knusbaum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the twirp serverhooks, so that the specific span that was started in
requestRoutedHookis finished inresponseSentHook. This way, other server hooks that modify the context may start new spans in the context without conflicting with this middleware.Fixes #725.