-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/twitchtv/twirp: Add explicit reference to the request span #726
Conversation
This should be ready. I've marked it as a draft for now, until the problem and solution in #725 are confirmed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment above about the context keys.
949c53a
to
9cea5e3
Compare
9cea5e3
to
6f22ca9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mickeyreiss The changes look great.
Would you mind adding a test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you don't mind, I added a test directly on your branch.
Thanks for the contribution. This will go out in 1.27.0
Perfect. Thanks for the help, @knusbaum! |
Refactor the twirp serverhooks, so that the specific span that was started in
requestRoutedHook
is finished inresponseSentHook
. This way, other server hooks that modify the context may start new spans in the context without conflicting with this middleware.Fixes #725.