ddtrace/tracer: improve agent connectivity check #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Sep 3, 2020
knusbaum
force-pushed
the
knusbaum/fix-agent-connect
branch
from
c823090
to
621e727
Compare
knusbaum
changed the title
Previously, the tracer would attempt to send an empty http POST to the transport's endpoint at startup. This PR adds an empty msgpack array to the request body and the X-Datadog-Trace-Count header to avoid causing decoding error messages in the agent Fixes #705
knusbaum
force-pushed
the
knusbaum/fix-agent-connect
branch
from
0d046ab
to
b27b8e1
Compare
|
Sorry, had to upmerge @gbbr |
gbbr
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the tracer would attempt to send an empty http POST to the
transport's endpoint at startup. This PR adds an empty msgpack array to the
request body and the X-Datadog-Trace-Count header to avoid causing decoding
error messages in the agent
Fixes #705