-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiler: add API key check at initialization of Profiler object #718
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
86bccc7
Add format-type API key check to profiler config
sanchda adaf3f5
profiler: API key check throws error
sanchda 50dd443
profiler: stylistic changes to please gofmt
sanchda fac9de7
profiler: fix additional linter complaints
sanchda 3af39db
profiler: get local tests running for api check
sanchda ef1b11d
profiler: sanitize API keys, address concerns
sanchda 23e4c86
profiler: remove API key sanitization
sanchda 4bf0ca5
profiler: update isAPIKeyValid to fail on extended ASCII input
sanchda 2e3c600
profiler: add tests for isAPIKeyValid
sanchda 32b4d37
profiler: add Profiler startup tests for API key
sanchda fd07880
profiler: streamline non-parametrized error
sanchda c124f1e
profiler: fix import issue from previous commit
sanchda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, maybe we can have just one global constant
testAPIKey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestions.
Writing the tests revealed an issue with non-ASCII glyphs returning true by unicode.IsLower(), so this already paid off.
Also added a simple positive and negative check for Profiler instantiation.