contrib/graph-gophers/graphql-go: Add WithOmitTrivial option. #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Sep 1, 2020
There was a problem hiding this comment.
Thanks for adding this. While contributions are welcome, please remember to read our contribution guidelines before starting to write code for a PR. Generally new additions to the code have to first be discussed in an issue. Please take this into consideration for the future.
The change is fine by me.
|
Thanks for the quick response! Sorry, I'll keep the guidelines in mind in the future. Should be all ready now. |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial fields are fields implemented by methods which can't return an error, they are usually just structure field reads. See the test.
With big object listings, the traces get very unreadable if you print a span for each field of each object.
In our use cases, this often reduces span counts in a trace by an order of magnitude.