Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: add support for various environment variables #696

Merged
merged 5 commits into from
Jul 22, 2020
Merged

ddtrace/tracer: add support for various environment variables #696

merged 5 commits into from
Jul 22, 2020

Conversation

knusbaum
Copy link
Contributor

@knusbaum knusbaum commented Jul 17, 2020 •
edited
Loading

This PR adds support for the following environment varables

  • DD_<INTEGRATION>_ANALYTICS_ENABLED
  • DD_RUNTIME_METRICS_ENABLED
  • DD_TRACE_DEBUG

gbbr
gbbr reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits. Please request a review via Github UI when ready.

internal/globalconfig/globalconfig.go Outdated Show resolved Hide resolved
ddtrace/tracer/option.go Outdated Show resolved Hide resolved
ddtrace/tracer/tracer.go Outdated Show resolved Hide resolved
brettlangdon
brettlangdon requested changes Jul 21, 2020
View reviewed changes
contrib/Shopify/sarama/option.go Outdated Show resolved Hide resolved
@knusbaum
contrib: add support for DD_TRACE_<INTEGRATION>_ANALYTICS_ENABLED
5eb7657 
ddtrace/tracer: add support for DD_RUNTIME_METRICS_ENABLED
ddtrace/tracer: add support for DD_TRACE_DEBUG
@knusbaum
fixup
c7ba592
@knusbaum knusbaum modified the milestones: 1.26.0, 1.27.0 Jul 21, 2020
@knusbaum knusbaum marked this pull request as ready for review July 21, 2020 18:46
@knusbaum knusbaum mentioned this pull request Jul 21, 2020
Closed
gbbr
gbbr previously approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful. Thanks Kyle!

internal/env.go Outdated Show resolved Hide resolved
@knusbaum @gbbr
Update internal/env.go
f021af8 
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
@gbbr
Copy link
Contributor

gbbr commented Jul 22, 2020

@brettlangdon need your approval

@knusbaum knusbaum modified the milestones: 1.27.0, 1.26.0 Jul 22, 2020
@knusbaum knusbaum merged commit 6d7c52c into v1 Jul 22, 2020
@knusbaum knusbaum deleted the knusbaum/env-sync branch July 22, 2020 13:44
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
@knusbaum @mingrammer
ddtrace/tracer: add support for various environment variables (DataDo…
829ed80 
…g#696)

This PR adds support for the following environment variables:

DD_<INTEGRATION>_ANALYTICS_ENABLED which enables analytics for the named integration,
DD_RUNTIME_METRICS_ENABLED which enables runtime metrics for the tracer
DD_TRACE_DEBUG which enables debug mode for the tracer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@gbbr gbbr gbbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@knusbaum @gbbr @brettlangdon