-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: add support for various environment variables #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
reviewed
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some nits. Please request a review via Github UI when ready.
brettlangdon
requested changes
Jul 21, 2020
ddtrace/tracer: add support for DD_RUNTIME_METRICS_ENABLED ddtrace/tracer: add support for DD_TRACE_DEBUG
knusbaum
force-pushed
the
knusbaum/env-sync
branch
from
July 21, 2020 18:16
041ea03
to
c7ba592
Compare
gbbr
previously approved these changes
Jul 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful. Thanks Kyle!
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
gbbr
approved these changes
Jul 22, 2020
@brettlangdon need your approval |
brettlangdon
approved these changes
Jul 22, 2020
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
…g#696) This PR adds support for the following environment variables: DD_<INTEGRATION>_ANALYTICS_ENABLED which enables analytics for the named integration, DD_RUNTIME_METRICS_ENABLED which enables runtime metrics for the tracer DD_TRACE_DEBUG which enables debug mode for the tracer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the following environment varables
DD_<INTEGRATION>_ANALYTICS_ENABLED
DD_RUNTIME_METRICS_ENABLED
DD_TRACE_DEBUG