Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: add support for DD_TRACE_ANALYTICS_ENABLED env. var. #691

Merged
merged 3 commits into from
Jul 21, 2020

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Jul 7, 2020

This change adds support for the DD_TRACE_ANALYTICS_ENABLED environment
variable, which will enable App Analytics for web integrations.

@gbbr gbbr added the core label Jul 7, 2020
@gbbr gbbr added this to the 1.26.0 milestone Jul 7, 2020
Copy link

@andrewardito andrewardito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

ddtrace/tracer/option.go Outdated Show resolved Hide resolved
ddtrace/tracer/option.go Show resolved Hide resolved
@gbbr gbbr requested a review from knusbaum July 8, 2020 07:58
knusbaum
knusbaum previously approved these changes Jul 9, 2020
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

ddtrace/tracer/option.go Outdated Show resolved Hide resolved
gbbr and others added 3 commits July 17, 2020 16:51
This change adds support for the DD_TRACE_ANALYTICS_ENABLED environment
variable, which will enable App Analytics for web integrations.
@knusbaum knusbaum merged commit 9abaf0b into v1 Jul 21, 2020
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
…ataDog#691)

This change adds support for the DD_TRACE_ANALYTICS_ENABLED environment
variable, which will enable App Analytics for web integrations.
@Julio-Guerra Julio-Guerra deleted the gbbr/DD_TRACE_ANALYTICS branch December 13, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants