ddtrace/tracer: add startup logging #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knusbaum
force-pushed
the
knusbaum/startup-logging
branch
from
4ebaa0a
to
70f153b
Compare
knusbaum
commented
Jun 26, 2020
gbbr
suggested changes
Jun 29, 2020
knusbaum
force-pushed
the
knusbaum/startup-logging
branch
from
cc6a517
to
6e54158
Compare
gbbr
reviewed
Jun 30, 2020
gbbr
reviewed
Jul 1, 2020
gbbr
reviewed
Jul 2, 2020
This commit adds a json-formatted log line to tracer startup in order make debugging the tracer easier.
gbbr
reviewed
Jul 6, 2020
gbbr
reviewed
Jul 6, 2020
labbati
reviewed
Jul 6, 2020
There was a problem hiding this comment.
Thanks @knusbaum for the work on this. I left a few comments.
Additionally:
- I am not seeing the json object to be prepended by
DATADOG TRACER CONFIGURATION. This is useful so both devs here in issues and our solutions team can ask to search in logs for that key phrase and copy/paste the value. - Every check that we do and fails (e.g. agent connectivity) should have an additional line
DATADOG TRACER DIAGNOSTICS. So, as an example, for the fieldagent_errorif it fails we should have both a message in theagent_errorfield (that will be copied an pasted to us) and a unique line in the logs with the same message containing the wordsDATADOG TRACER DIAGNOSTICS.
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
knusbaum
commented
Jul 6, 2020
There was a problem hiding this comment.
I'm not happy with the verboseness of the DATADOG TRACER DIAGNOSTICS and DATADOG TRACER CONFIGURATION prefixes.
Instead, I'm just including DIAGNOSTICS and CONFIGURATION.
Then the logs will begin:
Datadog Tracer v1.26.0 WARN: DIAGNOSTICS
and
Datadog Tracer v1.26.0 INFO: CONFIGURATION
Does this work, @labbati, @gbbr ?
gbbr
reviewed
Jul 7, 2020
There was a problem hiding this comment.
This is good, but:
- Please add tests for the returned error messages, it would be nice if they would be displayed as:
Error parsing DD_....:
at index 1: ...
at index 4: ...
- The caps are terrible, why are they needed?
- The verbosity of the logs is also not great and seems unnecessary.
Co-authored-by: Gabriel Aszalos <gabriel.aszalos@gmail.com>
…e-go into knusbaum/startup-logging
gbbr
approved these changes
Jul 8, 2020
|
Perfect. Your changes look great. |
knusbaum
added a commit
that referenced
this pull request
Jul 14, 2020
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
This commit adds a json-formatted log line and other diagnostic messages to tracer startup in order make debugging the tracer easier.
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
The merge of DataDog#692 conflicted with tests from DataDog#685, causing failures in ddtrace/tracer/log_test.go There were also tests added in DataDog#685 in ddtrace/tracer/sampler_test.go which fail in go1.14 due to changes in json parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a json-formatted log line to tracer startup in order make
debugging the tracer easier.
This is part of an effort that spans all tracers, and should follow the specification.
The basic idea is to collect commonly-needed information as the tracer starts up and report it in one json-formatted log line.