Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/go.mongodb.org/mongo-driver: add span type #683

Merged
merged 1 commit into from
Jun 29, 2020

Conversation

cgilmour
Copy link
Contributor

This was reported to Datadog support. Without specifying a span type, the span renders as "custom".
Added the tag and updated the test to ensure it's set. This matches contrib/globalsign/mgo.

@cgilmour cgilmour added this to the 1.26.0 milestone Jun 17, 2020
@cgilmour cgilmour requested a review from knusbaum June 17, 2020 03:07
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbbr gbbr merged commit 057f9e8 into v1 Jun 29, 2020
@gbbr gbbr deleted the cgilmour/mongodb-span-type branch June 29, 2020 08:02
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants