Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: add quotes to trace and span id in format #676

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

knusbaum
Copy link
Contributor

@knusbaum knusbaum commented Jun 4, 2020

The backend prefers strings to integers when it comes to parsing
dd.trace_id and dd.span_id.

@knusbaum knusbaum added this to the 1.25.0 milestone Jun 4, 2020
@knusbaum knusbaum requested review from gbbr and NBParis June 4, 2020 20:31
gbbr
gbbr previously approved these changes Jun 5, 2020
@NBParis
Copy link

NBParis commented Jun 5, 2020

@PierreVanRoy for visibility so we can add such examples to the Go logging pipelines.

The backend prefers strings to integers when it comes to parsing
dd.trace_id and dd.span_id.
@gbbr gbbr merged commit 307997d into v1 Jun 5, 2020
@gbbr gbbr deleted the knusbaum/id-quotes branch June 5, 2020 13:02
@gbbr gbbr restored the knusbaum/id-quotes branch June 5, 2020 13:06
gbbr added a commit that referenced this pull request Jun 5, 2020
@knusbaum knusbaum deleted the knusbaum/id-quotes branch June 5, 2020 14:35
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
The backend prefers strings to integers when it comes to parsing
dd.trace_id and dd.span_id.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants