ddtrace/tracer: add WithHTTPClient and increase default HTTP timeout #636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
added
enhancement
knusbaum
previously approved these changes
Apr 15, 2020
Co-Authored-By: Kyle Nusbaum <kyle.nusbaum@datadoghq.com>
gbbr
force-pushed
the
gbbr/withhttpclient
branch
from
f775c0e
to
bb09f00
Compare
cgilmour
approved these changes
Apr 16, 2020
|
I'm looking forward to this feature :) |
|
It'll be out in a few days |
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
…ataDog#636) This change adds a new option `WithHTTPClient` and marks `WithHTTPRoundTripper` as deprecated (now superseded). Additionally, the default client timeout is increased to 2 seconds as it has proven to be too short (see DataDog#181). Closes DataDog#181 Co-authored-by: Kyle Nusbaum <kyle.nusbaum@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new option
WithHTTPClientand marksWithHTTPRoundTripperas deprecated (now superseded). Additionally, thedefault client timeout is increased to 2 seconds as it has proven to be
too short (see #181).
Closes #181