-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: add WithHTTPClient and increase default HTTP timeout #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @gbbr
Just a documentation nit.
Co-Authored-By: Kyle Nusbaum <kyle.nusbaum@datadoghq.com>
f775c0e
to
bb09f00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving. It was already reviewed and approved.
I'm looking forward to this feature :) |
It'll be out in a few days |
…ataDog#636) This change adds a new option `WithHTTPClient` and marks `WithHTTPRoundTripper` as deprecated (now superseded). Additionally, the default client timeout is increased to 2 seconds as it has proven to be too short (see DataDog#181). Closes DataDog#181 Co-authored-by: Kyle Nusbaum <kyle.nusbaum@datadoghq.com>
This change adds a new option
WithHTTPClient
and marksWithHTTPRoundTripper
as deprecated (now superseded). Additionally, thedefault client timeout is increased to 2 seconds as it has proven to be
too short (see #181).
Closes #181