contrib/gin-gonic/gin: correct resource name #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a mistake with setting the resource name for this integration. We previously had used `(*gin.Context).HandlerName` to set the resource which was wrong and returns the name of the function (e.g. `main.main.func1`). This change ensures that the resource name is set correctly, as in all our HTTP integrations to method and path (e.g. "GET /path")
knusbaum
force-pushed
the
knusbaum/restore-574
branch
from
345568d
to
da7798e
Compare
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
There was a mistake with setting the resource name for this integration. We previously had used `(*gin.Context).HandlerName` to set the resource which was wrong and returns the name of the function (e.g. `main.main.func1`). This change ensures that the resource name is set correctly, as in all our HTTP integrations to method and path (e.g. "GET /path")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't actually need to revert #574. That was my mistake. At any rate, this will put the v1 branch back where we want it.
There was a mistake with setting the resource name for this integration.
We previously had used
(*gin.Context).HandlerNameto set the resourcewhich was wrong and returns the name of the function (e.g.
main.main.func1).This change ensures that the resource name is set correctly, as in all
our HTTP integrations to method and path (e.g. "GET /path")