ddtrace/tracer: simplify channels #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
added
the
enhancement
This change slightly simplifies concurrency, moves some test methods to the test files, improves naming to be more consistent and adds more documentation.
gbbr
force-pushed
the
gbbr/simplify-channels
branch
from
76f6b78
to
f0ef7b3
Compare
clutchski
reviewed
Sep 18, 2019
cgilmour
approved these changes
Sep 19, 2019
cgilmour
reviewed
Sep 19, 2019
| @@ -289,7 +292,7 @@ func (t *tracer) Extract(carrier interface{}) (ddtrace.SpanContext, error) { | |||
| } | |||
|
|
|||
| // flush will push any currently buffered traces to the server. | |||
| func (t *tracer) flush() { | |||
| func (t *tracer) flushPayload() { | |||
There was a problem hiding this comment.
The comment should be updated to flushPayload.
gbbr
added a commit
that referenced
this pull request
Jan 15, 2020
During a previous change released as part of v1.20.0 in PR #498, the flush channel was accidentally made blocking. This would cause a deadlock on occasion when flushing after the payload was full. Tests failed to catch this problem because they were not using the constructor and instead had their own, which was made correctly. This change also addresses that problem and removes the constructor from the tests, now correctly reproducing the problem.
gbbr
added a commit
that referenced
this pull request
Jan 15, 2020
During a previous change released as part of v1.20.0 in PR #498, the flush channel was accidentally made blocking. This would cause a deadlock on occasion when flushing after the payload was full. Tests failed to catch this problem because they were not using the constructor and instead had their own, which was made correctly. This change also addresses that problem and removes the constructor from the tests, now correctly reproducing the problem.
gbbr
added a commit
that referenced
this pull request
Jan 15, 2020
During a previous change released as part of v1.20.0 in PR #498, the flush channel was accidentally made blocking. This would cause a deadlock on occasion when flushing after the payload was full. Tests failed to catch this problem because they were not using the constructor and instead had their own, which was made correctly. This change also addresses that problem and removes the constructor from the tests, now correctly reproducing the problem.
gbbr
added a commit
that referenced
this pull request
Jan 15, 2020
During a previous change released as part of v1.20.0 in PR #498, the flush channel was accidentally made blocking. This would cause a deadlock on occasion when flushing after the payload size became large. Tests failed to catch this problem because they were not using the constructor and instead had their own incorrect constructor. This change also addresses that problem so that tests would now correctly catch the issue.
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
This change slightly simplifies concurrency, moves some test methods to the test files, improves naming to be more consistent and adds more documentation.
mingrammer
pushed a commit
to mingrammer/dd-trace-go
that referenced
this pull request
Dec 22, 2020
During a previous change released as part of v1.20.0 in PR DataDog#498, the flush channel was accidentally made blocking. This would cause a deadlock on occasion when flushing after the payload size became large. Tests failed to catch this problem because they were not using the constructor and instead had their own incorrect constructor. This change also addresses that problem so that tests would now correctly catch the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change slightly simplifies concurrency, moves some test methods to
the test files, improves naming to be more consistent and adds more
documentation.
Eventually, what is now
flushChancan also go away, but it's a bigger pieceof work that requires a lot of test rewriting.