Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/appsec: better docs #2935

Merged
merged 2 commits into from
Oct 22, 2024
Merged

internal/appsec: better docs #2935

merged 2 commits into from
Oct 22, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

Better docs for Appsec design

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Oct 21, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-10-21 13:09:11

Comparing candidate commit 8c4600f in PR branch eliott.bouhana/emitter-listeners-docs with baseline commit 2cae09f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@eliottness eliottness marked this pull request as ready for review October 21, 2024 12:26
@eliottness eliottness requested a review from a team as a code owner October 21, 2024 12:26
@eliottness
internal/appsec: better docs
5f0bdc5 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness
internal/appsec: better docs
8c4600f 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness force-pushed the eliott.bouhana/emitter-listeners-docs branch from 3d81eb3 to 8c4600f Compare October 21, 2024 12:26
@RomainMuller RomainMuller merged commit d48348e into main Oct 22, 2024
166 checks passed
@RomainMuller RomainMuller deleted the eliott.bouhana/emitter-listeners-docs branch October 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliottness @RomainMuller