Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/civisibility: add support for the test.source.end tag #2911

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

tonyredondo
Copy link
Member

What does this PR do?

This PR adds a logic to calcule the test.source.end tag with the end line number of a test function using the ast parser. It's a best effort approach, in case we cannot extract it (eg: no source code is available) then we silently bail out.

Motivation

This part of the CI Visibility specs.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo tonyredondo self-assigned this Oct 4, 2024
@tonyredondo tonyredondo marked this pull request as ready for review October 4, 2024 11:08
@tonyredondo tonyredondo requested a review from a team as a code owner October 4, 2024 11:08
@tonyredondo tonyredondo merged commit 966abf2 into main Oct 4, 2024
144 of 145 checks passed
@tonyredondo tonyredondo deleted the tony/civisibility-test-source-end-support branch October 4, 2024 11:48
MNThomson pushed a commit to agilebits/dd-trace-go that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants