Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/civisibility: fixes the test parent status when the auto-retry feature ended up with a failed test and then a successful test. #2910

Merged
merged 2 commits into from
Oct 4, 2024
Merged

internal/civisibility: fixes the test parent status when the auto-retry feature ended up with a failed test and then a successful test. #2910

merged 2 commits into from
Oct 4, 2024

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Oct 4, 2024 •
edited
Loading

What does this PR do?

This PR fixes the scenario when a test fail after retrying and then a test passes, before the PR we were always setting the test parent status according the current test status, so a previous failure status gets overwrote by a test passing status.

Motivation

This is fix on an actual bug in the implementation.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@tonyredondo
internal/civisibility: fixes the test parent status when the autoretr…
82f4758 
…y feature ended up with a failed test and after that there's a successful test.
@tonyredondo tonyredondo requested a review from a team as a code owner October 4, 2024 08:45
@tonyredondo tonyredondo self-assigned this Oct 4, 2024
@tonyredondo tonyredondo changed the title internal/civisibility: fixes the test parent status when the auto-retry feature ended up with a failed test and after that there's a successful test. internal/civisibility: fixes the test parent status when the auto-retry feature ended up with a failed test and then a successful test. Oct 4, 2024
ManuelPalenzuelaDD
ManuelPalenzuelaDD approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@ManuelPalenzuelaDD ManuelPalenzuelaDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a comment about updating a string

internal/civisibility/integrations/gotesting/testing_test.go Outdated Show resolved Hide resolved
@tonyredondo tonyredondo merged commit d50070a into main Oct 4, 2024
144 of 145 checks passed
@tonyredondo tonyredondo deleted the tony/civisiblity-auto-test-retry-parent-failure-fix branch October 4, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManuelPalenzuelaDD ManuelPalenzuelaDD ManuelPalenzuelaDD approved these changes

@vitor-de-araujo vitor-de-araujo vitor-de-araujo approved these changes

Assignees

@tonyredondo tonyredondo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyredondo @ManuelPalenzuelaDD @vitor-de-araujo