Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for ancient and unused grpc.v12 #2820

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

ajgajg1134
Copy link
Contributor

What does this PR do?

Drop our contrib library wrapping grpc v0.12.0

Motivation

This grpc version is really old, has high level CVE issues and is a huge pain to test and support. To improve maintainability let's drop it. Checking our data on usage here suggests there are actually ZERO current users of this.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 19, 2024
@ajgajg1134 ajgajg1134 marked this pull request as ready for review August 19, 2024 15:37
@ajgajg1134 ajgajg1134 requested review from a team as code owners August 19, 2024 15:37
@pr-commenter
Copy link

pr-commenter bot commented Aug 19, 2024

Benchmarks

Benchmark execution time: 2024-08-19 15:56:05

Comparing candidate commit 84620ff in PR branch andrew.glaude/byebyeoldGRPC with baseline commit 1bb170a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@zarirhamza zarirhamza merged commit e4985df into main Aug 19, 2024
186 checks passed
@zarirhamza zarirhamza deleted the andrew.glaude/byebyeoldGRPC branch August 19, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants