Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: update the expected telemetry tags for OTel env-var mapping #2797

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented Jul 25, 2024

What does this PR do?

The expected telemetry tags when reporting OTel env-var mapping issues now use snake-case:

 config.datadog       -> config_datadog
 config.opentelemetry -> config_opentelemetry

The expected tag values should also be lower-case.

Motivation

The RFC has been revised since #2715

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@mcculls mcculls force-pushed the mcculls/otel-env-var-metric-tag-update branch from 91a7e8c to e41aa1c Compare July 25, 2024 11:47
@pr-commenter
Copy link

pr-commenter bot commented Jul 25, 2024

Benchmarks

Benchmark execution time: 2024-07-25 12:38:07

Comparing candidate commit f09a5fb in PR branch mcculls/otel-env-var-metric-tag-update with baseline commit 05a8b5a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
@DataDog DataDog deleted a comment from github-actions bot Jul 25, 2024
…with the latest RFC

  config.datadog       -> config_datadog
  config.opentelemetry -> config_opentelemetry

The expected tag values should also be lower-case.
@mcculls mcculls force-pushed the mcculls/otel-env-var-metric-tag-update branch from e41aa1c to f09a5fb Compare July 25, 2024 12:15
@mcculls mcculls marked this pull request as ready for review July 25, 2024 13:11
@mcculls mcculls requested a review from a team as a code owner July 25, 2024 13:11
@darccio
Copy link
Member

darccio commented Jul 25, 2024

@mcculls Can we safely assume that the telemetry backend will handle both formats, right?

@mcculls
Copy link
Contributor Author

mcculls commented Jul 25, 2024

@mcculls Can we safely assume that the telemetry backend will handle both formats, right?

The metric definitions were only recently added to telemetry intake allow list in https://github.com/DataDog/dd-go/pull/142947 (using the latest format from the RFC - the reason for the change was that the dotted names are not valid tag names for telemetry)

@darccio darccio merged commit b5aa285 into main Jul 25, 2024
164 checks passed
@darccio darccio deleted the mcculls/otel-env-var-metric-tag-update branch July 25, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants