Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction how to update Go version for macrobenchmarks #2793

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

ddyurchenko
Copy link
Collaborator

@ddyurchenko ddyurchenko commented Jul 17, 2024

What does this PR do?

  1. Adds instruction how to update Go version for macrobenchmarks.
  2. Adds retries for macrobenchmarks that failed due to internal Gitlab errors (which are expected to happen 1 in ca. 900 runs on avg).

Motivation

Go macrobenchmarks were broken since last Thursday due to e8dc974, because Docker image was not updated with newer Go versions.

I've already updated the image in background, so now the pipeline is fixed.

This PR adds more specific instructions on updating Go versions.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ddyurchenko ddyurchenko requested a review from a team as a code owner July 17, 2024 16:29
@ddyurchenko ddyurchenko force-pushed the ddyurchenko/add-version-update-disclaimer branch 2 times, most recently from 5df6338 to 27d1ff0 Compare July 17, 2024 16:40
@ddyurchenko ddyurchenko force-pushed the ddyurchenko/add-version-update-disclaimer branch from 27d1ff0 to 7dd006f Compare July 17, 2024 16:47
@ddyurchenko ddyurchenko added the ci label Jul 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2024

Benchmarks

Benchmark execution time: 2024-07-17 16:51:18

Comparing candidate commit dc8b651 in PR branch ddyurchenko/add-version-update-disclaimer with baseline commit 0a6bcb7 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics.

Copy link
Contributor

@nsrip-dd nsrip-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ddyurchenko ddyurchenko merged commit 9e05fc2 into main Jul 17, 2024
164 checks passed
@ddyurchenko ddyurchenko deleted the ddyurchenko/add-version-update-disclaimer branch July 17, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants