internal: cache build info to reduce lock contention in GetGitMetadataTags #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reverting to draft to investigate a bit more. |
darccio
force-pushed
the
dario.castane/reduce-lock-contention-getgitmetadata
branch
2 times, most recently
from
ec06787
to
048ef48
Compare
darccio
changed the title
BenchmarksBenchmark execution time: 2024-07-12 14:58:20 Comparing candidate commit fcb1ad4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics. |
darccio
force-pushed
the
dario.castane/reduce-lock-contention-getgitmetadata
branch
from
048ef48
to
1ab3ea6
Compare
darccio
force-pushed
the
dario.castane/reduce-lock-contention-getgitmetadata
branch
from
1ab3ea6
to
f4ac899
Compare
eliottness
approved these changes
Jul 12, 2024
Co-authored-by: Eliott Bouhana <47679741+eliottness@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces caching code to avoid calling
debug.ReadBuildInfomultiple times each time a span is finished. It's cached on package initialisation.Note: it's important to know that it's not possible to test
debug.ReadBuildInfobecause test binaries have no debug info, according to golang/go#33976.Motivation
This was detected as an important lock contention area using our Continuous Profiler on one of our busiest services. It should help to reduce lock contention, with potential reduction around 15%.
Reviewer's Checklist
Unsure? Have a question? Request a review!