contrib: add log/slog instrumentation #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
apm:ecosystem
rarguelloF
changed the title
BenchmarksBenchmark execution time: 2024-07-01 12:02:12 Comparing candidate commit 21aa203 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics. |
|
|
||
| // WrapHandler enhances the given logger handler attaching tracing information to logs. | ||
| func WrapHandler(h slog.Handler) slog.Handler { | ||
| return &handler{h} |
There was a problem hiding this comment.
I think this may be an unnecessary heap allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a new instrumentation for https://pkg.go.dev/log/slog
This instrumentation provides log / trace correlation for
log/slogusers: https://docs.datadoghq.com/tracing/other_telemetry/connect_logs_and_traces/Motivation
Solves #2077
Reviewer's Checklist
Unsure? Have a question? Request a review!