Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddtrace/tracer: update the tag naming convention for otel env var telemetry metrics #2760

Merged
merged 6 commits into from
Jul 3, 2024
Merged

ddtrace/tracer: update the tag naming convention for otel env var telemetry metrics #2760

merged 6 commits into from
Jul 3, 2024

Conversation

khanayan123
Copy link
Contributor

@khanayan123 khanayan123 commented Jun 25, 2024 •
edited
Loading

What does this PR do?

Updates the tag naming convention for otel env var telemetry metrics

Motivation

Update tag naming convention based on update to otel env var mapping RFC

@khanayan123 khanayan123 marked this pull request as ready for review June 25, 2024 20:04
@khanayan123 khanayan123 requested a review from a team as a code owner June 25, 2024 20:04
@pr-commenter
Copy link

pr-commenter bot commented Jun 25, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-06-27 15:17:21

Comparing candidate commit 0ab5295 in PR branch khanayan123/update-otel-env-metric-tag-names with baseline commit 27d60de in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

zacharycmontoya
zacharycmontoya approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'll defer to Diana for the Go suggestions 😄

@khanayan123 @dianashevchenko
Update ddtrace/tracer/otel_dd_mappings.go
9c8d662 
Co-authored-by: Diana Shevchenko <40775148+dianashevchenko@users.noreply.github.com>
@khanayan123 khanayan123 marked this pull request as draft June 27, 2024 14:48
@khanayan123 khanayan123 changed the title update otel env telemetry metric tag naming ddtrace/tracer: update otel env telemetry metric tag naming Jun 27, 2024
@khanayan123 khanayan123 changed the title ddtrace/tracer: update otel env telemetry metric tag naming ddtrace/tracer: update the tag naming convention for otel env var telemetry metrics Jun 27, 2024
@khanayan123 khanayan123 marked this pull request as ready for review June 27, 2024 15:10
@darccio darccio enabled auto-merge (squash) July 3, 2024 09:42
@darccio darccio removed the request for review from dianashevchenko July 3, 2024 09:42
@darccio darccio merged commit 127fa9a into main Jul 3, 2024
162 of 163 checks passed
@darccio darccio deleted the khanayan123/update-otel-env-metric-tag-names branch July 3, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darccio darccio darccio approved these changes

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@dianashevchenko dianashevchenko dianashevchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanayan123 @darccio @zacharycmontoya @dianashevchenko