Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove one colon check for well-formed edge tags #2729

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

juliannzhou
Copy link
Contributor

What does this PR do?

This PR removes the one colon check for well-formed edge tags.

Motivation

https://dd.slack.com/archives/C06P5GB4UT1/p1717608298448609

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@juliannzhou juliannzhou requested a review from a team as a code owner June 5, 2024 17:58
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2024

Benchmarks

Benchmark execution time: 2024-06-11 14:03:43

Comparing candidate commit e0b0135 in PR branch juliann.zhou/remove-one-colon-tag-check with baseline commit d789322 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@darccio
Copy link
Member

darccio commented Jun 6, 2024

@piochelepiotr Is it safe to release the previuosly merged PR or I should wait for this PR?

@piochelepiotr
Copy link
Collaborator

@piochelepiotr Is it safe to release the previuosly merged PR or I should wait for this PR?

@piochelepiotr Is it safe to release the previuosly merged PR or I should wait for this PR?

It's safe to release the previously merged PR.

{"type::dog", false},
{"type:d:o:g", false},
{"type::", false},
{"type::dog", true},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test for a sns arn, and make sure it passes.

@juliannzhou
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 10, 2024

❌ MergeQueue

You are not allowed to use the merge queue towards main.

If you need support, contact us on Slack #devflow with those details!

@juliannzhou juliannzhou requested a review from darccio June 10, 2024 19:08
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darccio darccio merged commit 028515c into main Jun 11, 2024
158 checks passed
@darccio darccio deleted the juliann.zhou/remove-one-colon-tag-check branch June 11, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants