-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove one colon check for well-formed edge tags #2729
Conversation
BenchmarksBenchmark execution time: 2024-06-11 14:03:43 Comparing candidate commit e0b0135 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics. |
@piochelepiotr Is it safe to release the previuosly merged PR or I should wait for this PR? |
It's safe to release the previously merged PR. |
{"type::dog", false}, | ||
{"type:d:o:g", false}, | ||
{"type::", false}, | ||
{"type::dog", true}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a test for a sns arn, and make sure it passes.
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
This PR removes the one colon check for well-formed edge tags.
Motivation
https://dd.slack.com/archives/C06P5GB4UT1/p1717608298448609
Reviewer's Checklist
Unsure? Have a question? Request a review!