Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: increment droppedP0Traces iff it's not going to be sent #2713

Merged
merged 3 commits into from
May 30, 2024

Conversation

darccio
Copy link
Member

@darccio darccio commented May 27, 2024

What does this PR do?

Reduce reported dropped traces by increasing the counter only when the chunk won't be sent.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team as a code owner May 27, 2024 09:56
@pr-commenter
Copy link

pr-commenter bot commented May 27, 2024

Benchmarks

Benchmark execution time: 2024-05-29 08:17:33

Comparing candidate commit 650ee60 in PR branch dario.castane/report-drop-only-iff-not-willsend with baseline commit b913c87 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 0 unstable metrics.

@darccio darccio merged commit 9126b4f into main May 30, 2024
158 checks passed
@darccio darccio deleted the dario.castane/report-drop-only-iff-not-willsend branch May 30, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants