Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddtrace/tracer: added support for metrics tag sampling #2662

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

dianashevchenko
Copy link
Contributor

What does this PR do?

This PR extends the support for sampling rules. Previously, sampling was ran on meta tags only, now it is available for the numerics as well.

Also, this PR fixes case sensitivity of the string tags (for both keys and values)

Motivation

The Extended Sampling RFC

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@dianashevchenko dianashevchenko requested a review from a team as a code owner April 18, 2024 17:57
@dianashevchenko dianashevchenko force-pushed the shevchenko/sampling-by-metric-tag branch from 245c18d to cfb65e9 Compare April 18, 2024 18:08
@pr-commenter
Copy link

pr-commenter bot commented Apr 18, 2024

Benchmarks

Benchmark execution time: 2024-04-18 18:39:39

Comparing candidate commit 5b3abba in PR branch shevchenko/sampling-by-metric-tag with baseline commit af0486a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 0 unstable metrics.

@dianashevchenko dianashevchenko merged commit 7df262e into main Apr 19, 2024
158 checks passed
@dianashevchenko dianashevchenko deleted the shevchenko/sampling-by-metric-tag branch April 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants