-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[contrib/gocql] reporting both cluster and datacenter #2577
[contrib/gocql] reporting both cluster and datacenter #2577
Conversation
BenchmarksBenchmark execution time: 2024-07-09 08:15:04 Comparing candidate commit 1c2d7c2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics. |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This PR was closed because it has been open for 30 days with no activity. |
We'll have to introduce a mechanism to make sure customers expecting the old behaviour can keep using it. We are discussing the best way to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see this unblocked. Looks great!
What does this PR do?
Report both cluster and datacenter.
Quoting this Datastax doc
An Apache Cassandra Datacenter is a group of nodes, related and configured within a cluster for replication purposes.
For users that are relying on the previous behavior and want to stay with it, they can set the env variable
DD_TRACE_GOCQL_COMPAT=v1.65
.Also as a side quest it updates the CI image to 3.11 which:
Motivation
Report more insightful metadata.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!