Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[contrib/gocql] reporting both cluster and datacenter #2577

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

ufoot
Copy link
Contributor

@ufoot ufoot commented Feb 26, 2024

What does this PR do?

Report both cluster and datacenter.

  • Cluster is really the cluster name as in "the DB name".
  • Datacenter is a Cassandra specific notion, which can be used in some cases to host the same data on multiple datacenters, etc.

Quoting this Datastax doc An Apache Cassandra Datacenter is a group of nodes, related and configured within a cluster for replication purposes.

For users that are relying on the previous behavior and want to stay with it, they can set the env variable DD_TRACE_GOCQL_COMPAT=v1.65.

Also as a side quest it updates the CI image to 3.11 which:

  • is the latest of the 3.x series (soon unmaintained, but switching to 4.x is a bigger change)
  • has arm64 support out-of-the box, when the 3.7 was only amd64 compatible (at least this is what I witnessed on my laptop)

Motivation

Report more insightful metadata.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Feb 26, 2024
@ufoot ufoot marked this pull request as ready for review February 26, 2024 16:50
@ufoot ufoot requested review from a team as code owners February 26, 2024 16:50
@pr-commenter
Copy link

pr-commenter bot commented Feb 26, 2024

Benchmarks

Benchmark execution time: 2024-07-09 08:15:04

Comparing candidate commit 1c2d7c2 in PR branch christian/gocql-report-cluster-name-and-datacenter with baseline commit 79fd68c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 1 unstable metrics.

Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stuck for more than 1 month label Mar 18, 2024
Copy link

This PR was closed because it has been open for 30 days with no activity.

@github-actions github-actions bot closed this Apr 17, 2024
@ufoot ufoot reopened this Jun 19, 2024
@ufoot ufoot requested a review from a team as a code owner June 19, 2024 19:22
@darccio darccio removed the stale Stuck for more than 1 month label Jul 2, 2024
@darccio
Copy link
Member

darccio commented Jul 2, 2024

We'll have to introduce a mechanism to make sure customers expecting the old behaviour can keep using it.

We are discussing the best way to do this.

@rarguelloF
Copy link
Contributor

@darccio @ufoot I went ahead and pushed some changes:

For users that are relying on the previous behavior and want to stay with it, they can set the env variable DD_TRACE_GOCQL_COMPAT=v1.65.

Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see this unblocked. Looks great!

@darccio darccio merged commit a20143b into main Jul 9, 2024
196 checks passed
@darccio darccio deleted the christian/gocql-report-cluster-name-and-datacenter branch July 9, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants