internal/apps: better tagging #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not running the test apps on PRs anymore, so there is no way to invoke the jobs without either the workflow_call or workflow_dispatch inputs being available. So we need no pr_default values to fall back to.
BenchmarksBenchmark execution time: 2023-12-12 10:03:08 Comparing candidate commit 90dc5d5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics. |
Work around the fact that workflow_dispatch triggers can only have a maximum of 10 inputs, ugh. See links below for more info. - https://github.com/DataDog/dd-trace-go/actions/runs/7179140710 - https://github.com/orgs/community/discussions/8774
felixge
force-pushed
the
felix.geisendoerfer/PROF-8773-better-tagging
branch
from
028614c
to
90dc5d5
Compare
felixge
changed the title
ahmed-mez
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
trigger:weeklyortrigger:nightlytag to scheduled test-app runsDD_TAGSwhen manually triggering test-app runsMotivation
Make it easier to find the data for nightly, weekly and manually triggered test-app runs in the trace explorer and profile search.
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!