-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/valyala/fasthttp.v1: add a fasthttp integration to ddtrace #2305
Conversation
This is resolved in commit #43a2ed7. |
Is this when running the tests for the new package you're adding, or the whole test suite? The latter doesn't work with Let me know if you need help debugging. |
I want to make sure we add documentation for how to use the integration, like the example for net/http contrib - https://pkg.go.dev/gopkg.in/DataDog/dd-trace-go.v1/contrib/net/http#example-package |
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 🎉
Left some refactor suggestions. Also we should make sure we add an example_test.go
file with a ExampleWrapHandler
function to make sure we provide documentation to users on how to use the integration.
Co-authored-by: Rodrigo Argüello <rodrigo.arguello@datadoghq.com>
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 0s) you can cancel this operation by commenting your pull request with |
🚨 MergeQueue mergequeue build completed successfully, but the github api returned an error while merging the pr Details
Error: PUT https://api.github.com/repos/DataDog/dd-trace-go/pulls/2305/merge: 405 5 of 5 required status checks are expected. [] FullStacktrace: If you need support, contact us on slack #ci-interfaces with those details! |
What does this PR do?
Provides middleware to trace requests handled with the FastHTTP library: https://pkg.go.dev/github.com/valyala/fasthttp
Motivation
Customer requests!
#700
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!