-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2 experimentation]profiler: remove WithAPIKey and WithAgentlessUpload #2224
[V2 experimentation]profiler: remove WithAPIKey and WithAgentlessUpload #2224
Conversation
BenchmarksBenchmark execution time: 2023-09-22 13:43:25 Comparing candidate commit 0a7f739 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking API change. Please ping me in slack to provide more context on this. Thanks!
cc @nsrip-dd
Edit: Talked to Jennie about this in slack. This is for v2 and not going into the main branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
88d4fbc
into
jennie.gao/v2-experimentation-main
What does this PR do?
Remove
WithAPIKey
option#866
Motivation
TLDR:
Agentless uploading is originally supported if customer set
DD_API_KEY
env variable, or useWithAPIKey
option.WithAgentlessUpload
was introduced for debugging purpose when agentless mode is disabled forWithAPIKey
option.Due to business reasons we want to deprecate agentless support for public uses, only allow internal usage by explicitly set
DD_PROFILING_AGENTLESS
andDD_API_KEY
env variable.This PR is to remove
WithAPIKey
andWithAgentlessUpload
option.More context: Agentless vs Agent Uploading
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!