Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2 experimentation]profiler: remove WithAPIKey and WithAgentlessUpload #2224

Merged

Conversation

JianyiGao
Copy link
Contributor

@JianyiGao JianyiGao commented Sep 19, 2023

What does this PR do?

Remove WithAPIKey option
#866

Motivation

TLDR:
Agentless uploading is originally supported if customer set DD_API_KEY env variable, or use WithAPIKey option. WithAgentlessUpload was introduced for debugging purpose when agentless mode is disabled for WithAPIKey option.

Due to business reasons we want to deprecate agentless support for public uses, only allow internal usage by explicitly set DD_PROFILING_AGENTLESS and DD_API_KEY env variable.

This PR is to remove WithAPIKey and WithAgentlessUpload option.

More context: Agentless vs Agent Uploading

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@JianyiGao JianyiGao added the v2.0 label Sep 19, 2023
@pr-commenter
Copy link

pr-commenter bot commented Sep 19, 2023

Benchmarks

Benchmark execution time: 2023-09-22 13:43:25

Comparing candidate commit 0a7f739 in PR branch jennie.gao/remove-withapikey with baseline commit 2ac90e1 in branch jennie.gao/v2-experimentation-main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@JianyiGao JianyiGao marked this pull request as ready for review September 19, 2023 16:19
@JianyiGao JianyiGao requested a review from a team as a code owner September 19, 2023 16:19
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking API change. Please ping me in slack to provide more context on this. Thanks!

cc @nsrip-dd

Edit: Talked to Jennie about this in slack. This is for v2 and not going into the main branch.

profiler/options.go Outdated Show resolved Hide resolved
@JianyiGao JianyiGao changed the title profiler: remove WithAPIKey [V2 experimentation]profiler: remove WithAPIKey and WithAgentlessUpload Sep 21, 2023
profiler/options.go Outdated Show resolved Hide resolved
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JianyiGao JianyiGao merged commit 88d4fbc into jennie.gao/v2-experimentation-main Sep 25, 2023
50 checks passed
@JianyiGao JianyiGao deleted the jennie.gao/remove-withapikey branch September 25, 2023 15:44
@JianyiGao JianyiGao restored the jennie.gao/remove-withapikey branch November 13, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants