Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgraded github.com/DataDog/go-libddwaf v1.4.2 => v1.5.0 #2166

Closed
wants to merge 1 commit into from

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Aug 4, 2023

What does this PR do?

$ go get -u -v github.com/DataDog/go-libddwaf@v1.5.0
go: downloading github.com/DataDog/go-libddwaf v1.5.0
go: upgraded github.com/DataDog/go-libddwaf v1.4.2 => v1.5.0
go: upgraded github.com/ebitengine/purego v0.5.0-alpha => v0.5.0-alpha.0.20230803142445-813050efbc99

Motivation

Condensed changelog of go-libddwaf:

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness requested a review from a team as a code owner August 4, 2023 10:55
@eliottness
Copy link
Contributor Author

eliottness commented Aug 4, 2023

Here are the Smoke Tests and the Appsec Tests workflows

@pr-commenter
Copy link

pr-commenter bot commented Aug 4, 2023

Benchmarks

Benchmark execution time: 2023-08-04 11:06:17

Comparing candidate commit 43ffa83 in PR branch eliott.bouhana/bump-go-libddwaf with baseline commit c4cf034 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics.

@eliottness
Copy link
Contributor Author

Cc @Hellzy

@eliottness eliottness deleted the eliott.bouhana/bump-go-libddwaf branch October 25, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant