Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: auto trigger major workflows on release branches #1631

Merged
merged 3 commits into from
Dec 30, 2022

Conversation

Julio-Guerra
Copy link
Contributor

What does this PR do?

  1. Automatically run the important workflows on release-v* branches
  2. Remove the release automation workflows which no longer work due to https://github.com/orgs/community/discussions/25305 when we recently reinforced our repo settings.

Motivation

Ease the release process and documentation.

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@Julio-Guerra Julio-Guerra added this to the v1.46.0 milestone Dec 19, 2022
@Julio-Guerra Julio-Guerra marked this pull request as ready for review December 19, 2022 15:27
@Julio-Guerra Julio-Guerra requested review from a team as code owners December 19, 2022 15:27
Copy link
Contributor

@knusbaum knusbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea to run these on release branches. However, where do the results go? Do we get alerted on failures or do we have to go and find the runs for the release branches and check them?

@pr-commenter
Copy link

pr-commenter bot commented Dec 28, 2022

Benchmarks

Comparing candidate commit 1e27f20 in PR branch julio.guerra/release-workflows with baseline commit cb93051 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 6 cases.

@Hellzy
Copy link
Contributor

Hellzy commented Dec 28, 2022

The person that pushes to the branch should get the notification as long as they subscribe to GH actions notifications, we - go guild members - won't get automatically alerted on the other hand.
I'm thinking that it's fine since this only impacts release branches, that are push protected.

@Hellzy Hellzy merged commit a76b1cb into main Dec 30, 2022
@Hellzy Hellzy deleted the julio.guerra/release-workflows branch December 30, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants