Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec/waf: fix memory release condition #1583

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Nov 16, 2022

What does this PR do?

Fix function releasing the WAF results' memory.

Motivation

Memory leaks can happen due to a wrong condition in the function.

Describe how to test/QA your changes

Running our reliability environment for a day and see the memory usage doesn't grow anymore.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Changed code has unit tests for its functionality.
  • If this interacts with the agent in a new way, a system test has been added.

@Julio-Guerra Julio-Guerra marked this pull request as ready for review November 17, 2022 10:33
@Julio-Guerra Julio-Guerra requested a review from a team as a code owner November 17, 2022 10:33
@Julio-Guerra Julio-Guerra added this to the v1.44.0 milestone Nov 17, 2022
@Julio-Guerra Julio-Guerra added bug unintended behavior that has to be fixed appsec labels Nov 17, 2022
@Julio-Guerra Julio-Guerra merged commit 1190584 into main Nov 17, 2022
@Julio-Guerra Julio-Guerra deleted the julio.guerra/fix-appsec-leak branch November 17, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec bug unintended behavior that has to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants