contrib/net/http nil transport should default to http.DefaultTransport #1572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1223
If a nil transport is provided to
WrapRoundTripper
, default tohttp.DefaultTransport
Motivation
The following program panics at runtime:
The panic comes when
httpClient.Get
is called even though nil shouldn't be a valid parameter forWrapRoundTripper
. In some programs, that panic might not come as quickly as seen above.This is interesting because go itself does not require a transport to be specific on the http.Client as it falls back to the http.DefaultTransport. As such, it's not uncommon for an http client to be created without explicitly specifying the transport.
Describe how to test/QA your changes
N/A
Reviewer's Checklist
Triage
milestone is set.