-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/aws/aws-sdk-go: expose handler names as const #1524
Conversation
I don't see any reason not to expose these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, forgot this nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Tests actually passed, they just failed to upload some results. This is fixed in another PR. Since the tests are mandatory, we have to wait for it. |
Thanks for the quick review! |
I am directly modifying handlers in the request stack, and referencing them
ByName
will be safer if these are exposed.Reference: #1168 (comment)