Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/telemetry: support DD_TELEMETRY_HEARTBEAT_INTERVAL #1475

Merged
merged 3 commits into from
Sep 22, 2022

Conversation

katiehockman
Copy link
Contributor

This change decouples the heartbeat signal and flushing data to the backend, and adds support for a configurable DD_TELEMETRY_HEARTBEAT_INTERVAL environment variable.

See https://github.com/DataDog/instrumentation-telemetry-api-docs/blob/main/GeneratedDocumentation/ApiDocs/v1/producing-telemetry.md#configurable-interval for more details.

This change decouples the heartbeat signal and flushing data to the backend, and adds support for a configurable DD_TELEMETRY_HEARTBEAT_INTERVAL environment variable.

See https://github.com/DataDog/instrumentation-telemetry-api-docs/blob/main/GeneratedDocumentation/ApiDocs/v1/producing-telemetry.md#configurable-interval for more details.
@katiehockman katiehockman added this to the 1.43.0 milestone Sep 21, 2022
@katiehockman katiehockman requested a review from a team as a code owner September 21, 2022 15:53
nsrip-dd
nsrip-dd previously approved these changes Sep 22, 2022
internal/telemetry/client.go Show resolved Hide resolved
internal/telemetry/client_test.go Show resolved Hide resolved
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@katiehockman katiehockman merged commit 464cc6a into main Sep 22, 2022
@katiehockman katiehockman deleted the katie.hockman/telemetry-heartbeat-interval branch September 22, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants