Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiler: start collecting profiles immediately #1417

Merged
merged 4 commits into from
Aug 8, 2022

Commits on Aug 5, 2022

  1. profiler: start collecting profiles immediately

    Previously, it would take two minutes for the first profile to be
    uploaded. One minute for the internal time.Ticker to fire, and then an
    additional minute to collect the profiles for the first time. This means
    we wouldn't get profiles for the first minute of activity.
    
    Two tests had to be changed due to this:
    
    * TestStartStopIdempotency became significantly slower, because it would
      start 5000 profiles, and stopping each one involved waiting 200 ms
      for the CPU profile to stop. Changed to just collect the heap profile
      and to do fewer iterations.
    * TestProfilerInternal broke because it expected one round of profiling
      to happen after the "ticker" fired, but now one happens sooner so you
      see multiple profiles. It also broke because the test was supposed to
      close p.exit, not send to it. In general, the test is too tied to the
      specific implementation. TestAllUploaded covers all the same behavior
      and more, and didn't get broken by this implementation change. So I
      opted to just delete TestProfilerInternal.
    nsrip-dd committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    cfc755a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    310cada View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. profiler: typo fix

    nsrip-dd committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    3071eca View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Configuration menu
    Copy the full SHA
    0db7a3f View commit details
    Browse the repository at this point in the history