Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/cloud.google.com/go/pubsub.v1: add Option to Publish #1332

Merged
merged 10 commits into from
Oct 26, 2022

Conversation

hakankutluay
Copy link
Contributor

Add service name and measured options to the Publish and WrapReceiveHandler

closes #1141

Add service name and measured options to the Publish and WrapReceiveHandler

closes DataDog#1141
@hakankutluay hakankutluay requested a review from a team June 9, 2022 09:46
gbbr
gbbr previously approved these changes Jun 9, 2022
Copy link
Contributor

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks! Just a small nit.

contrib/cloud.google.com/go/pubsub.v1/pubsub.go Outdated Show resolved Hide resolved
gbbr
gbbr previously approved these changes Jun 10, 2022
@gbbr gbbr added this to the 1.39.0 milestone Jun 10, 2022
@Hellzy Hellzy modified the milestones: 1.39.0, 1.40.0 Jul 1, 2022
@Hellzy Hellzy modified the milestones: 1.40.0, 1.41.0 Jul 15, 2022
@Hellzy Hellzy modified the milestones: 1.41.0, 1.42.0 Aug 16, 2022
@hakankutluay
Copy link
Contributor Author

hakankutluay commented Aug 18, 2022

May I ask, is there anything required to merge the PR ?

@knusbaum knusbaum modified the milestones: 1.42.0, 1.43.0 Sep 19, 2022
@vigo
Copy link

vigo commented Sep 20, 2022

when the merge will happen? :)

@hakankutluay
Copy link
Contributor Author

hakankutluay commented Oct 14, 2022

Is there anything that blocks this PR to merge? @knusbaum @gbbr

@Julio-Guerra Julio-Guerra modified the milestones: 1.43.0, v1.44.0 Oct 18, 2022
@hakankutluay
Copy link
Contributor Author

Is there anything that blocks this PR to merge? @knusbaum @gbbr @Julio-Guerra

@ajgajg1134 ajgajg1134 merged commit 0577015 into DataDog:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal contrib/cloud.google.com/go/pubsub.v1: add StartSpanOption to pubsub.Publish
7 participants