You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now the fiber integration doesn't set the error information on the spans, like it's done for echo. Instead of seeing the actual error info, the span is only marked with a status code error. Is there some specific reason for it or could it be improved? I'd be happy to work on a PR if possible :)
The error returned from the fiber handler was being ignored
by the middleware. It now correctly captures the error and
sets it on the span.
FixesDataDog#978
Right now the fiber integration doesn't set the error information on the spans, like it's done for echo. Instead of seeing the actual error info, the span is only marked with a status code error. Is there some specific reason for it or could it be improved? I'd be happy to work on a PR if possible :)
Echo: https://github.com/DataDog/dd-trace-go/blob/v1/contrib/labstack/echo.v4/echotrace.go#L55
Fiber: https://github.com/DataDog/dd-trace-go/blob/v1/contrib/gofiber/fiber.v2/fiber.go#L69
The text was updated successfully, but these errors were encountered: